-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different crystal frequencies bootloader #553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Annoying that we have to lug around some more bootloaders, but given that we've only seen 26mhz xtals on the esp32 and esp32c2, its not too bad.
Thanks for working on this!
As usual, I forgot to update the changelog, so I just did it and also formatted other changelog entries |
Maybe you can steal our CI config on esp-hal and esp-wifi to make sure we add entries. That can wait for another PR though, if you wish! |
This was discussed when we added the changelog, #416 (comment), but we decided not to add it as it also has drawbacks |
I think that was before we fixed the fork issue around |
Yes that was before we figured out how to properly use the workflow, no problem to add it now I think. |
flash
use the target xtal_freq to choose the bootloadersave-image
add a-x/--xtal-freq
arg to choose the bootloader.XtalFrequency
enum to avoid hardcoded values.