-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read-flash support #558
Conversation
@t-moe also confirmed that it worked for him: #539 (comment) |
6f8a2f2
to
1afded2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Feel free to ignore the comment about reverting the enum names, it's not a big deal and I'm guessing this brings us inline with esptools naming convention?
1afded2
to
1b85a07
Compare
1b85a07
to
d2580ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Tests
espflash
esptool