Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Set RTS before DTR to avoid issues #562

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Windows: Set RTS before DTR to avoid issues #562

merged 4 commits into from
Feb 1, 2024

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Jan 25, 2024 •
edited
Loading

Supersedes #554

I couldn't verify that this actually works as I have not encountered this issue, see #554 and esptool workaround

@MabezDev
Copy link
Member

MabezDev commented Feb 1, 2024

@bjoernQ would you mind testing this just to ensure it still works on windows after this change?

bjoernQ
bjoernQ approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly the same as before for me. Tried with a few different boards (using different Windows drivers)

@MabezDev
Copy link
Member

MabezDev commented Feb 1, 2024

Thank you for testing @bjoernQ! LGTM!

@MabezDev MabezDev merged commit d7f800e into esp-rs:main Feb 1, 2024
20 checks passed
@SergioGasquez SergioGasquez deleted the fix/windows-reset branch February 1, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergioGasquez @MabezDev @bjoernQ @haileys