-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flash/monitoring of 26mhz targets #584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
force-pushed
the
fix/flash-26mhz
branch
from
February 15, 2024 18:19
960c966
to
d6a73d9
Compare
bjoernQ
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - works fine for me with both 26 and 40 MHz ESP32-C2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidSerialRead
erroresp-flasher-stub
, which usesesp-hal
with the changes of this branch: esp-rs/esp-hal@main...SergioGasquez:esp-hal:feat/clk-srcThanks @bjoernQ for the help resolving this issue
I've reverted the changes for ESP32, as I dont have a 26MHz to test it, I dont know if anyone from the team has one, and ESP32 cant choose
xtal_clock
as UART source. From ESP32 TRM:Tests
rng
example of esp-hal to a 26MHz C2 and a 40MHz C2 with no issues