Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list-all-ports flag and filter the default list #590

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Feb 20, 2024

Draft PR until it can be properly tested and we verify that it closes #575
@jessebraham verified that it resolves #575, thanks for testing it!

@SergioGasquez SergioGasquez marked this pull request as ready for review February 21, 2024 21:14
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@MabezDev MabezDev merged commit cd49141 into esp-rs:main Feb 23, 2024
20 checks passed
@SergioGasquez SergioGasquez deleted the feat/port-list branch February 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serial port selection provides too many options, some of which are invalid
2 participants