Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resolving non-code addresses #603

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 26, 2024

This improves how we resolve non-code addresses.

Before

load:0x40080400,len:4
0x40080400 - _DoubleExceptionVector
    at ??:??
ho 8 tail 4 room 4
load:0x40080404,len:3876
0x40080404 - _DoubleExceptionVector
    at ??:??
entry 0x4008064c
0x4008064c - __user_exception
    at C:\Users\Bjoern\.cargo\registry\src\index.crates.io-6f17d22bba15001f\esp-backtrace-0.11.0\src\lib.rs:130

After

load:0x40080400,len:4
ho 8 tail 4 room 4
load:0x40080404,len:3876
entry 0x4008064c
0x4008064c - __user_exception
    at C:\Users\Bjoern\.cargo\registry\src\index.crates.io-6f17d22bba15001f\esp-backtrace-0.11.0\src\lib.rs:130

__user_exception is still confusing but at least it's the same result as xtensa-esp32-elf-addr2line

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 26, 2024

@SergioGasquez I remember you looked into that openssl build problem before?

@SergioGasquez
Copy link
Member

@SergioGasquez I remember you looked into that openssl build problem before?

Yes, feel free to ignore it for the moment. See #602 and #597

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is much nicer! FYI this now brings the output inline with idf's monitor program, it prints the __user_exception (under a different name though), so I think this is the best we're going to get right now.

@bjoernQ bjoernQ merged commit 8353080 into esp-rs:main Feb 26, 2024
27 of 28 checks passed
@bjoernQ bjoernQ deleted the improve-non-code-address-resolving branch February 26, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants