Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for next esp-hal release / esp-wifi release #37

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 29, 2024

  • there are some links to docs.rs which we cannot change before we have documentation available for the next release (i.e. after that release)**
  • some of the solutions are available online via Wokwi - I have no idea how we can update them. I guess they are hosted on wokwi.com and owned by Sergio, so only he can change it. We shouldn't update them before the next esp-hal release anyways

** these links

❯ rg docs.rs/esp32
book\src\03_5_http_client.md
95:[timer]: https://docs.rs/esp32c3-hal/latest/esp32c3_hal/systimer/index.html
96:[clock]: https://docs.rs/esp32c3-hal/latest/esp32c3_hal/clock/index.html

book\src\03_4_interrupt.md
61:[listen]: https://docs.rs/esp32c3-hal/latest/esp32c3_hal/prelude/trait._esp_hal_gpio_Pin.html#method.listen
64:[possible interrupts]: https://docs.rs/esp32c3/0.5.1/esp32c3/enum.Interrupt.html
65:[events]: https://docs.rs/esp32c3-hal/latest/esp32c3_hal/gpio/enum.Event.html#variants

book\src\03_3_button.md
39:[into-pull-up-input]: https://docs.rs/esp32c3-hal/latest/esp32c3_hal/gpio/struct.GpioPin.html#method.into_pull_up_input
40:[into-push-pull-output]: https://docs.rs/esp32c3-hal/latest/esp32c3_hal/gpio/struct.GpioPin.html#method.into_push_pull_output

book\src\03_2_blinky.md
44:[into-push-pull-output]: https://docs.rs/esp32c3-hal/latest/esp32c3_hal/gpio/struct.GpioPin.html#method.into_push_pull_output

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Thanks for taking care of this!

advanced/stack-overflow-detection/Cargo.toml Show resolved Hide resolved
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Mar 11, 2024

Just waiting for next esp-wifi release which is blocked by a problem with ESP32-S2

@bjoernQ bjoernQ marked this pull request as ready for review March 12, 2024 16:42
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Mar 12, 2024

This should now be ready to merge

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SergioGasquez SergioGasquez merged commit e50c0d5 into esp-rs:main Mar 12, 2024
10 checks passed
@SergioGasquez
Copy link
Member

Forgot to update here: All the Wokwi examples are now updated to match the source code in the training

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants