Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install GCC for selected targets when not installing esp-idf #108

Merged
merged 6 commits into from
Jul 15, 2022

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Jul 14, 2022

  • If we are not installing esp-idf we need to install GCC for the targets passed with -b|--build-target.
  • cleared ${IDF_TOOL_XTENSA_ELF_CLANG}/bin/ from $PATH as with the minified version of LLVM is no longer present.
  • We now clear downloaded files by default (CLEAR_DOWNLOAD_CACHE="YES")

Closes #107, #85, and #52

@SergioGasquez SergioGasquez linked an issue Jul 14, 2022 that may be closed by this pull request
Copy link
Collaborator

@georgik georgik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make the removal of GCC more generic.

install-rust-toolchain.sh Outdated Show resolved Hide resolved
@SergioGasquez
Copy link
Member Author

@svenstaro @kyrias thanks for reporting the issues, can you confirm that this branch solves all the issues?

install-rust-toolchain.sh Outdated Show resolved Hide resolved
@kyrias
Copy link
Contributor

kyrias commented Jul 14, 2022

This works great, other than the extraneous colons in the generated $PATH.

@SergioGasquez
Copy link
Member Author

I did a few more changes as it was not working properly when using: ./install-rust-toolchain.sh --build-target esp32c3

@georgik georgik merged commit 0fb8efb into main Jul 15, 2022
@SergioGasquez SergioGasquez deleted the fix/gcc-installation branch July 15, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants