-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1850 from 4m1g0/fixPSK
Allow PSK instead of passphrase in WiFiSTA::begin
- Loading branch information
Showing
1 changed file
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e82b74e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bump from 63 to 64 is fine, but the extra code to do a memcpy instead of a strcpy, when you're already using strlen to determine the length, and the PSK is required to be ascii, is completely pointless and a needless complication.
e82b74e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Further, using strlen to determine whether it's safe to use strcpy is completely _UN_safe)