Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://docs.python.org/3/library/tempfile.html#tempfile.mkstemp
read_segment()
'sdumpfile
was never deleted, producing 5 'segment' files each build.Instead, this patch creates a temporary directory which is later used for objcopy output.
TemporaryDirectory()
context manager will handle the deletion.Plus, some minor refactoring to reduce line length and add some pythonisms (hopefully, not too much)
Noticed this issue accidentally by inspecting a specific Windows PC install using WSL circa January.
/tmp
was ~2.5GB and there was a lot of files.