Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding possibility to manually set MD5 checksum for HTTP update #8204

Merged
merged 2 commits into from
Sep 4, 2021

Conversation

vlastahajek
Copy link
Contributor

I've written a library that allows updating from Github releases. To verify firmware integrity HTTPUpdater already supports MD5 checksum, but is only read from the server response header. This is not possible if there is no control of the server.
If a checksum is known from another source, it is not possible to set it. This PR allows this.

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this change, it seems to only affect the debug output and nothing more. The new ‘md5’ variable isn’t used outside the print, so I don’t see what the intent is here. The description leads me to believe you wanted to override the check on some way.

@vlastahajek
Copy link
Contributor Author

vlastahajek commented Jul 9, 2021

@earlephilhower, thanks for the quick and detailed review. I've fixed the wrong merge of the locally modified file.

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earlephilhower earlephilhower added this to the 3.1 milestone Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants