Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding esp32's ArduinoOTAClass::end function to esp8266 #8379

Merged
merged 3 commits into from
Dec 2, 2021
Merged

adding esp32's ArduinoOTAClass::end function to esp8266 #8379

merged 3 commits into from
Dec 2, 2021

Conversation

Phil1pp
Copy link
Contributor

@Phil1pp Phil1pp commented Nov 20, 2021

This adds the end() function for the ArduinoOTA class.

ESP32 has this implemented, however ESP8266 was lacking this.

earlephilhower
earlephilhower approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mcspr mcspr merged commit 0af18ab into esp8266:master Dec 2, 2021
@drzony drzony mentioned this pull request Feb 4, 2022
Merged
@ajschwieterman ajschwieterman mentioned this pull request Nov 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil1pp @earlephilhower @mcspr