Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards.txt.py: add Wemos ESP-WROOM-02 board #8664

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

rotulet
Copy link
Contributor

@rotulet rotulet commented Aug 30, 2022

Get fixes from #6551 (comment)

@mcspr
Copy link
Collaborator

mcspr commented Sep 1, 2022

Is it really a wemos board?
Shouldn't this be just esp wroom-02?

@rotulet
Copy link
Contributor Author

rotulet commented Sep 12, 2022

@mcspr good question! I have got the "official" Wemos logo on it. In many places on internet I found the same board branded Wemos but also clones. But I did not find any references on the Wemos web site!

@rotulet
Copy link
Contributor Author

rotulet commented Oct 8, 2022

@AronHetLam Sorry but I do not understand what is the error? Can you explain please?

@AronHetLam
Copy link

AronHetLam commented Oct 9, 2022

@rotulet, I'm not sure what exactly you are unsure about, but I'll explain the problem i had.
When I ran the script for the ESP-wroom-02 board i got an exception because there was no entry in the macros dict for flashfreq_26. Adding it, as you've done one the fix you pushed, fixed the issue for me, and i was able to generate a boards.txt with the entries needed for ESP-wroom-02.
I ran the scrip as standalone, and didn't look to deep into how it's all put together. As you can see in the issue I referenced this issue from, I had someone with a ESP-wroom-02 board that couldn't get my code compiled correctly.

@mcspr
Copy link
Collaborator

mcspr commented Oct 10, 2022

Simply run the boards script and commit changes to boards.txt and documentation.

Our Check expects that we have the same filesystem contents before and after running it
https://github.com/esp8266/Arduino/actions/runs/3099983428/jobs/5202829401
(unfold the crossed out section, it shows a git-diff output of what boards.txt.py generated and what changed in the repo)

@rotulet rotulet force-pushed the fix/add_d1_wroom_02 branch 3 times, most recently from 54af6a2 to dcdc3a7 Compare October 31, 2022 17:27
@rotulet
Copy link
Contributor Author

rotulet commented Oct 31, 2022

Sorry for the delay...

Thanks @mcspr for the hint!

@AronHetLam I updated the board.txt file and rebased on master.

@mcspr mcspr merged commit 78444a5 into esp8266:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants