Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic netif status callback and mDNS #8705

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Oct 31, 2022

follow up #8676

  • sprinkle IPAddress(...).isSet() across our loops to avoid polling on a stopped interface. status callback and netif_is_up does not guarantee and we could use the interface!
  • register one status callback per instance, e.g. when begin() is called multiple times (also notice a subtle issue with schedule function when instance is delete'ed)
  • consistent LwipIntf callback signature. no need for rvalue, just pass stdfunc as-is and let the compiler figure it out

* sprinkle IPAddress(...).isSet() across our loops to avoid polling on a
  stopped interface. status callback and netif_is_up **does not
  guarantee and we could use the interface**!
* register *one* status callback per instance, e.g. when begin() is called
  multiple times (also notice a subtle issue with schedule function when
  instance is delete'ed)
* consistent LwipIntf callback signature. no need for rvalue, just pass
  stdfunc as-is and let the compiler figure it out
@mcspr mcspr merged commit 04494f0 into esp8266:master Nov 1, 2022
@mcspr mcspr deleted the lwip/status-cb branch November 1, 2022 00:01
@mcspr mcspr added this to the 3.1 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More for fixing MDNS mDNS not working with WiFi.mode(WIFI_AP_STA) on current git
1 participant