Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Stream's parseFloat() #8785

Merged
merged 1 commit into from
Jan 3, 2023
Merged

fix Stream's parseFloat() #8785

merged 1 commit into from
Jan 3, 2023

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jan 3, 2023

cherry-pick updates for Stream::peekNextDigit() from AVR implementation: decimal dot is optionally allowed

fixes #8782

@d-a-v
fix Stream::parseFloat()
c63fe12 
cherry-pick updates for Stream::peekNextDigit() from AVR implementation
@mcspr mcspr added this to the 3.1 milestone Jan 3, 2023
@mcspr mcspr merged commit 5a3da9a into esp8266:master Jan 3, 2023
@earlephilhower
Copy link
Collaborator

Apropos of nothing, it's somewhat amusing that the decimal separator is hardcoded to a . by Arduino.cc even though in the Italian locale they use commas for the decimal separator. 😆

@d-a-v
Copy link
Collaborator Author

d-a-v commented Jan 3, 2023

It's without any regret that I copied this patch.
Decimal commas are hurting computing.

(Note: French decimal separator is also a comma)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parseFloat is not able to parse positive float numbers
3 participants
@d-a-v @earlephilhower @mcspr