Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 400b stack allocation from AdvWeb example #8793

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

earlephilhower
Copy link
Collaborator

The AdvancedWebServer.ino example allocated a 400 byte char array on the stack which, in the case of the example, will work but in general is a dangerous thing to show new users to try.

Instead, use a StreamString to generate the string on the heap.

The AdvancedWebServer.ino example allocated a 400 byte char array on the
stack which, in the case of the example, will work but in general is a
dangerous thing to show new users to try.

Instead, use a StreamString to generate the string on the heap.
@earlephilhower earlephilhower merged commit c8dcded into esp8266:master Jan 7, 2023
@earlephilhower earlephilhower deleted the no400b branch January 7, 2023 18:01
@mcspr mcspr added this to the 3.1.1 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants