Remove stale patch for SDK v1.1 and earlier #8858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rts_reg
addresses referenced are not valid for SDK v2.0.0 and up. Forrts_reg[30] = 0;
on SDK v1.1.0, it cleared a checksum. On SDL v2.0.0, it zerosTestStaFreqCalValInput
.I don't think this is needed; however, if you have a need to recreate the old behavior for comparison, use
RF_PRE_INIT()
as shown:Long long ago
In the beginning, before the release of Arduino ESP8266 Core v2.0.0-rc1
We were using SDK
v1.1.0
. This version of the SDK stored the results of a call todeep_sleep_set_option()
atrtc_reg[24]
. And kept an RTC memory checksum atrtc_reg[30]
.At the first file commit the patch looked like this:
Arduino/cores/esp8266/core_esp8266_phy.c
Lines 234 to 237 in dc08418
By the time of Core v2.0.0-rc1 we had a more selective patch:
When this commit was made Aug 5, 2015 the SDK version was around v1.1.0
Arduino/cores/esp8266/core_esp8266_phy.c
Lines 263 to 269 in e02932f
By the time of the release of Core v2.0.0-rc1 (Nov 17, 2015), we were using SDK v1.3.0 which no longer used those offsets in RTC memory. It is not clear to me that the patch was required anymore. And the message that often showed "RTC MEM CHECK FAIL!!!" was no longer in the SDK.
These issues may be entangled with the long version of the patch it is hard to sort out: