Add transparent HTTP/2 with spdy module

[ishitatsuyuki]

This adds an opt-out based HTTP/2 support based on node-spdy. It's tested on many Node version including 0.10, so there shouldn't be much risk of breakage.

[jankeromnes]

Nice! Very cool and surprisingly small change! Thanks a lot.

Would you mind adding a quick sanity check for this? I don't think we need to call all test-api.js tests on your new SPDY server (also the HTTP 1.1 check would fail), but maybe you could create a new file like /test/test-secure.js? (You can take inspiration from /test/test-api.js, e.g. for imports and the port-choosing boilerplate at the bottom, and then please add that file to make test, or to npm test directly).

[espadrine]

Very nice indeed!
Could you rebase it?

[espadrine]

It seems like SPDY is dying though: Chrome killed it in 2015, Firefox in 2016, so support is lacking. The npm package hasn't seen an update in a year.

Could you add support for HTTP/2 instead maybe? @jankeromnes Maybe you could help with the tests?

[ishitatsuyuki]

@espadrine Although this package is called spdy, it just supports H2 as well.

[espadrine]

@ishitatsuyuki My main worry is that the spdy package is likely to be deprecated in favour of the built-in HTTP/2 Node.js module (if it is not already so in the minds of the makers).

So we may not receive security updates or other important update (or any update at all).

[ishitatsuyuki]

@espadrine What I can say is that the official H2 module doesn't expose the Server class we have to use and thus cannot be inherited (apart from that, it's ABI isn't guaranteed to be stable). I'm aware that it's not well maintained, but it's still too early to switch to the official impl either.

[espadrine]

Good points! We'll figure out solutions to the http2 ordeal when it comes out of experimental status.

[espadrine]

@jankeromnes Would you be interested in contributing related tests as a follow-uip?

[jankeromnes]

@espadrine I won't have time to look into this anytime soon, sorry. Thanks for merging! And thanks @ishitatsuyuki for implementing this! 💯

[espadrine]

@ishitatsuyuki Hello! The SPDY module now crashes because of this 6-month old bug: spdy-http2/node-spdy#350

I am considering reverting this patch. Do you know a better solution by any chance?

[ishitatsuyuki]

It seems Node have implemented HTTP/2 as a reasonable built-in. I will do a rewrite this weekend.

[ishitatsuyuki]

Actually no, please revert this. Node ecosystem seems to have a number of bugs with the HTTP/2 module due to the class usage. (Additionally, sc uses inheritance which does not work with http2 because the SecureServer class is not exposed.)

They're listed in expressjs/express#3730, for reference.