Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf to 25.5 (aka PyPi 4.25.5) #992

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 6, 2024

Home Assistant currently uses protobuf==5.28.3 and only one major version ahead is technically supported so we seeing issues like home-assistant/core#129052 home-assistant/core#130169

Note that the problem only appears if C extensions are not working and protobuf falls back to the pure python version

Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #992 will not alter performance

Comparing protobuf_4_bump (3242f7c) with main (0221118)

Summary

✅ 2 untouched benchmarks

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0221118) to head (3242f7c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #992   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2673      2673           
=========================================
  Hits          2673      2673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hcjehg
Copy link

hcjehg commented Nov 9, 2024

It seems this has failed on
@github-actions CI / py 3.12 on ubuntu-latest (skip_cython) (pull_request) Failing after 1m

:-)

@hcjehg
Copy link

hcjehg commented Nov 16, 2024

It seems this still fails :-)
CI / py 3.12 on ubuntu-latest (skip_cython) (pull_request) Failing after 1m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants