Migrate validate dialog to Lit #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
commented
Jun 18, 2021
|
|
||
| shadowRoot.innerHTML = ` | ||
| <style> | ||
| .log { |
There was a problem hiding this comment.
This is copied from esphome.css. Can be removed from there once all log-based dialogs are migrated.
bramkragten
reviewed
Jun 18, 2021
| private _setup = false; | ||
|
|
||
| public connectedCallback() { | ||
| if (this._setup) { |
There was a problem hiding this comment.
Shouldn't we restart what we aborted if we connect again?
There was a problem hiding this comment.
Nah we should create a new process dialog
bramkragten
reviewed
Jun 18, 2021
| @@ -2,10 +2,10 @@ import { uploadModal } from "../legacy"; | |||
|
|
|||
| const preload = () => import("./install-update-dialog"); | |||
|
|
|||
| const startInstallUpdate = async (ev: Event) => { | |||
| export const openInstallDialog = async (filename: string) => { | |||
| preload(); | |||
| const dialog = document.createElement("esphome-install-dialog"); | |||
There was a problem hiding this comment.
Do we have to create a new dialog element every time, or should we re-use it? Do we also remove the dialog when we close it?
bramkragten
reviewed
Jun 18, 2021
bramkragten
approved these changes
Jun 18, 2021
Co-authored-by: Bram Kragten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the validate dialog and the foundation (log modal) to Lit.
Unblocks other migrations mentioned in #4.