Prepare for ESP32-C6 support #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not add support for it in the wizard ? |
|
Because until ESPHome updates the esp-idf and platformio versions to be at a minimum where C6 support was added, it just doesnt work 🙈 It requires the user to manually change those versions in yaml until such a time. |
balloob
reviewed
Nov 13, 2023
src/const.ts
Outdated
| | "RP2040"; | ||
|
|
||
| export type PlatformData = { | ||
| label: string; | ||
| showInPickerTitle: boolean; | ||
| showInDeviceType: boolean; |
There was a problem hiding this comment.
Let's change this showInDeviceTypePicker maybe?
balloob
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the C6 to the supported platforms "list" and also adds a new key/value for removing items from the wizard.
I started by adding to the
SupportedPlatformsso thatchipFamilyToPlatformcould map it, but then typescript said I had to implement in thesupportedPlatformsobject too.So in terms of user facing changes, it is not shown in the wizard yet, but will allow web-flashing of a C6 configuration.