Fixing UART1 pins for esp-idf-v5.1-libs #8477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation. Previous pin use works but is inconsistent with C6 docs.
|
|
|
Thanks for the PR @petergjoel, adding @SuGlider for review. |
SuGlider
approved these changes
Aug 8, 2023
|
@petergjoel - Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changing pins of UART1 to be consistent with C6 documentation, RX=GPIO4, TX=GPIO5.
See https://docs.espressif.com/projects/espressif-esp-dev-kits/en/latest/_images/esp32-c6-devkitc-1-pin-layout.png
Notice that existing pin configuration ALSO works, but requires wiring that is inconsistent with the official doc of the C6.
Tests scenarios
Tested on ESP32-C6-DevKitC-1 connected to a SP3485 used (and tested) for MODBUS communication.
Related links
Please provide links to related issue, PRs etc.