Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change (3rd_party_board): XIAO_C3 delete the definition of pin A3 #9798

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

Lesords
Copy link
Contributor

@Lesords Lesords commented Jun 7, 2024

Description of Change

Delete the definition of pin A3

Reason

Because A3 corresponds to GPIO5, which happens to be ADC2, and ADC2 is not currently supported, so A3 is currently useless.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "chore: delete the definition of pin A3":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Lesords, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 94c17e5

@Lesords Lesords changed the title chore: delete the definition of pin A3 change: delete the definition of pin A3 Jun 7, 2024
@lucasssvaz
Copy link
Collaborator

Could you please fill the PR description for us to know why the pin is being removed ?

@Lesords
Copy link
Contributor Author

Lesords commented Jun 10, 2024

Could you please fill the PR description for us to know why the pin is being removed ?

Okay, I updated it now

@VojtechBartoska VojtechBartoska changed the title change: delete the definition of pin A3 change (3rd_party_board): delete the definition of pin A3 Jun 10, 2024
@VojtechBartoska VojtechBartoska changed the title change (3rd_party_board): delete the definition of pin A3 change (3rd_party_board): XIAO_C3 delete the definition of pin A3 Jun 10, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jun 13, 2024
@me-no-dev me-no-dev merged commit cbf1e94 into espressif:master Jun 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants