Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount the Repository under its name instead of app (RDT-315) #24

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

Fishwaldo
Copy link

I'm using this to build some examples in a component I'm developing
As per the developer documentation for the components, we should use a override_path in the idf_component.yml file for each example:
https://github.com/espressif/idf-component-manager/wiki#add-examples-to-the-component

The problem is that the base path is mounted as "app" and not the component name, so when idf was trying to resolve dependencies it was failing.

This change, mounts the code under the repository name instead of app, and this idf can resolve it using the path_override.

(maybe a better option would be to provide a config option to specify the path the repository is mounted under in the docker image?)

@github-actions github-actions bot changed the title Mount the Repository under its name instead of app Mount the Repository under its name instead of app (RDT-315) Nov 17, 2022
Copy link
Collaborator

@kumekay kumekay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fishwaldo

Thank you for the PR,
To my opinion your solution is sufficient and probably a special parameter is not needed.
For repos with more than one component, it wouldn't be a problem because components will be in properly named subdirectories

action.yml Outdated Show resolved Hide resolved
@kumekay
Copy link
Collaborator

kumekay commented Nov 30, 2022

@Fishwaldo Thank you for the improvement

@kumekay kumekay merged commit 3d4f4d6 into espressif:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants