feat(console): Added command getaddrinfo, set/get dnsserver to console_cmd_ping #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espressif-abhikroy
force-pushed
the
component/console_cmd_ping
branch
from
a5f7452
to
40dc9ed
Compare
espressif-abhikroy
requested review from
euripedesrocha,
gabsuren,
alisitsyn,
david-cermak and
kostaond
david-cermak
reviewed
Jun 7, 2024
david-cermak
reviewed
Jun 7, 2024
david-cermak
reviewed
Jun 7, 2024
| * | ||
| * @return esp_err_t Returns ESP_OK on success, or an error code on failure. | ||
| */ | ||
| static esp_err_t set_dns_server(uint32_t addr, esp_netif_dns_type_t type) |
There was a problem hiding this comment.
do we support only IPv4 addresses?
There was a problem hiding this comment.
The initial implementation was only for ipv4. Updated to use ipv6 also.
Now this is supported
setdnsserver 8.8.8.8 fe80::b0be:83ff:fe77:dd64 www.xyz.com
david-cermak
approved these changes
Jun 7, 2024
espressif-abhikroy
force-pushed
the
component/console_cmd_ping
branch
from
40dc9ed
to
34dd001
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| while ((esp_netif = esp_netif_next(esp_netif)) != NULL) { | ||
| #endif | ||
| struct sockaddr_in6 *ipv6 = (struct sockaddr_in6 *)res_tmp->ai_addr; | ||
| memcpy(dns.ip.u_addr.ip6.addr, &ipv6->sin6_addr, sizeof(dns.ip.u_addr.ip6.addr)); |
Check warning
Code scanning / clang-tidy
Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memcpy_s' in case of C11 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling] Warning
espressif-abhikroy
force-pushed
the
component/console_cmd_ping
branch
from
34dd001
to
01526fb
Compare
1.1.0 Features - Added command getaddrinfo, set/get dnsserver to console_cmd_ping (b80c19d)
espressif-abhikroy
force-pushed
the
component/console_cmd_ping
branch
from
01526fb
to
c41e889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added command getaddrinfo, setdnsserver, getdnsserver to console_cmd_ping component.
Removed WHOLE_ARCHIVE from CMakelist, and allows users to disable auto-registration of console_cmd_ping component.