Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(websocket): propagate esp_tls stack error and cert verify flags #630

Merged

Conversation

johanstokking
Copy link
Contributor

Even though the esp_tls_stack_err and esp_tls_cert_verify_flags are get, they are not propagated through event data. This fixes that.

I came across this because I noticed that an Mbed TLS error code that I was interested in (MBEDTLS_ERR_SSL_ALLOC_FAILED) was correctly logged by the component, but esp_tls_stack_err was uninitialized.

Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue!

These errors are even used(!) in examples, referring and printing some old/invalid values.

@david-cermak david-cermak self-assigned this Aug 19, 2024
@euripedesrocha euripedesrocha merged commit 60817dd into espressif:master Aug 20, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants