-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HID driver release 1.0.3 #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roma-jam LGTM!
@roma-jam Could we also include this little change? espressif/idf-extra-components#273 We must add a comment that not all mice report wheel status and the user is responsible for checking the report length before he access the |
@tore-espressif I will add this byte and remove the strict comparison by the length for boot report, because some devices could return more. Anyway, it is time to move to the full reports, not only boot (with ReportID field), because boot report isn't so interesting, as all the game pads and other cool things is a bit complicated than just keyboards and mice for boot mode. |
@tore-espressif I have tried to add that, but it breaks the example, because not all mice has these byte in boot mode (Mine doesn't).
Maybe, I can combine them all-in-one future feature release and keep current only with fixes for external Hubs. WDYT? |
Yes, sure. Let;s leave it for later. It seemed as an easy change... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried on HW with an external hub. LGTM.
@roma-jam can we merge this? |
8b9edcf
to
1b4e4ac
Compare
1b4e4ac
to
907f761
Compare
USB Host HID Class Driver v1.0.3 (Release)
General description
Changes
Details
xfer->context
field.