Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp_tinyusb): Provide default descriptors for Vendor specific class #62

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Sep 17, 2024

Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions, otherwise LGTM.

device/esp_tinyusb/usb_descriptors.c Outdated Show resolved Hide resolved
device/esp_tinyusb/descriptors_control.c Outdated Show resolved Hide resolved
device/esp_tinyusb/descriptors_control.c Outdated Show resolved Hide resolved
@tore-espressif
Copy link
Collaborator Author

@roma-jam Thank you for the review! I updated the code and added test for the vendor class

Copy link
Collaborator

@leeebo leeebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device/esp_tinyusb/descriptors_control.c Show resolved Hide resolved
@tore-espressif tore-espressif merged commit dfcb08a into master Sep 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants