Add CDC parsing host test #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tore-espressif
force-pushed
the
feature/cdc_acm_merge_open
branch
5 times, most recently
from
1fdc564
to
0dced5a
Compare
tore-espressif
force-pushed
the
feature/cdc_acm_merge_open
branch
from
0dced5a
to
57b9613
Compare
tore-espressif
force-pushed
the
feature/cdc_acm_merge_open
branch
2 times, most recently
from
a5d547c
to
7d93201
Compare
roma-jam
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Built locally, launched and got the line:
All tests passed (520 assertions in 11 test cases)
Cool, that we could use linux tests now!
Overall LGTM, just one basic idea about the naming. Check the notes. feel free to use the suggested names if you like them better.
Name of the file cdc_host_parsing.c seems not clear to me. Hard to say, what is inside the file. Maybe something as cdc_acm_descriptor_parsing.c or cdc_acm_host_descriptor.c would be better.
CDC ACM descriptor parsing helper calls notes left before.
|
Thank you for the review @roma-jam , I'll address the comments ASAP |
Update CDC-ACM test_app to IDF v5.0
tore-espressif
force-pushed
the
feature/cdc_acm_merge_open
branch
from
7d93201
to
c3ad19d
Compare
host/class/cdc/usb_host_cdc_acm/cdc_host_descriptor_parsing.c
Dismissed
Show dismissed
Hide dismissed
host/class/cdc/usb_host_cdc_acm/cdc_host_descriptor_parsing.c
Dismissed
Show dismissed
Hide dismissed
host/class/cdc/usb_host_cdc_acm/cdc_host_descriptor_parsing.c
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor that separates Descriptor parsing logic to a separate file with its own private API.
This new private API is than used with newly added USB mock, so we can test the parsing logic on Linux host tests.
There is a number of hardcoded USB descriptors of tested and verified CDC devices that must work with this driver.
TODO: