Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fixed failing CI because of idf-build-apps v2.5 #67

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Sep 27, 2024

- Upgraded class test_apps to v5.0
- Fixed idf-build-apps version to prevent future regressions
In commit espressif/esp-idf@660319e
the length of USB transfer is save as 'allocated' size, which can be larger than real size.
So we make sure the reset size is multiple of MPS.
Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM

@tore-espressif tore-espressif merged commit 787efe2 into master Sep 30, 2024
16 checks passed
@tore-espressif tore-espressif deleted the fix/ci branch September 30, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants