-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(pypi_release): Use build --sdist argument to avoid building non-universal whl (ESPTOOL-926) #1011
Conversation
👋 Hello matthuisman, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
the other option would be to do twine upload dist/*.tar.gz instead but this felt cleaner |
fb8656d
to
5de78d3
Compare
Hi @matthuisman, Thanks for looking into this and contributing! LGTM. We will merge ASAP and do a bugfix release. |
@radimkarnis thanks for quick merge I'd suggest yanking the previous release if possible as I suspect anyone using --prefer-binary will keep getting that broken whl. |
eacc94a changed from using
python setup.py sdist
to
python -m build
The latter now builds a .whl which got uploaded using twine on the 4.8.0 release (https://pypi.org/project/esptool/4.8.0/#files)
Unfortuatnely due to setup.py (https://github.com/espressif/esptool/blob/master/setup.py),
the whl that is built on ubuntu uses scripts instead of entry_points
This makes the whl incompatible with Windows systems and causes import error / no exe's created
See #1010
This change adds --sdist argument to build which tells it not to create the whl.
This allows all systems to just use the source and then do the correct setup.py behaviour
This change fixes the following bug(s):
#1010
I have tested this change with the following hardware & software combinations:
I have tested build --sdist locally in Ubuntu and then installing the results .tar.gz in both windows and ubuntu
I have run the esptool.py automated integration tests with this change and the above hardware:
NO TESTING