add argument to erase flash before flashing #344
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Sometimes we want to erase the whole chip because we use some partitions for other data (like OTA) which is not overwritten when flashed with new firmware. Currently, this makes this a 2 stage process (erase_flash ... then write_flash) - This change is intended to make this a one stage command.
As this is a new argument please advise if you prefer another format.
I have tested this change with the following hardware & software combinations:
ESP32, Windows 7, Python 3.6