Guard STATUS_QIE_BIT definition to ESP32/ESP32S2 #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only used there, which causes a "defined but not used" (-Wunused-const-variable) compiler error in newer versions of GCC. Rather than disable what is otherwise a useful compiler warning, make the definition conditional to the ESP32s. See espressif#499 for context.
|
Hi @paravoid , Thanks for this, change LGTM and good to know we can build the stub on gcc 9 with no other warnings. I've cherry-picked your commit into our internal review & merge queue, this PR will be updated when it merges. Angus |
|
Cherry-picked, thanks again @paravoid ! |
dobairoland
pushed a commit
to espressif/esptool-legacy-flasher-stub
that referenced
this pull request
May 30, 2024
Only used there, which causes a "defined but not used" (-Wunused-const-variable) compiler error in newer versions of GCC. Rather than disable what is otherwise a useful compiler warning, make the definition conditional to the ESP32s. See #499 for context. Merges espressif/esptool#501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only used there, which causes a "defined but not used"
(-Wunused-const-variable) compiler error in newer versions of GCC.
Rather than disable what is otherwise a useful compiler warning, make
the definition conditional to the ESP32s.
See #499 for context.