Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(idf): possible renaming in idf #187

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Conversation

hfudev
Copy link
Member

@hfudev hfudev commented Jan 28, 2023

No description provided.

@hfudev hfudev self-assigned this Jan 28, 2023
@@ -52,7 +52,8 @@ def __init__(
self.elf_file = self._get_elf_file()

# loadable elf file skip the rest of these
if self.sdkconfig.get('APP_BUILD_TYPE_ELF_RAM'):
# TODO to be improved in #186
if self.sdkconfig.get('APP_BUILD_TYPE_ELF_RAM') or self.sdkconfig.get('APP_BUILD_TYPE_RAM'):
Copy link
Member

@igrr igrr Jan 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an alternative, can we set app.is_loadable_elf via pytest.mark.parametrize in the test case itself?

(just to reduce the amount of knowledge the test framework needs about the IDF internals)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, I prefer #186 instead of setting it explicitly, since users may forget to set it again.

Copy link
Member

@igrr igrr Jan 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, what is the point of #186? sdkconfig file already contains all the options added by sdkconfig.rename, so if APP_BUILD_TYPE_ELF_RAM got renamed into APP_BUILD_TYPE_ELF, then sdkconfig should contain both options.

Edit: maybe we have this issue because pytest-embedded-idf reads sdkconfig.json, which unlike sdkconfig doesn't contain the values added for backwards compatibility.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. sorry I didn't explain #186 clearly. The reason that we're having this issue is like you said, the sdkconfig.json doesn't contain the history names.

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py330%1–2, 4
app.py22959%1–3, 6, 15, 22, 28, 30, 32
dut.py662857%1–5, 7, 9–12, 15, 26, 45, 50–52, 54, 60, 66–68, 99, 101–102, 121–122, 141, 171
gdb.py44440%1–5, 7, 10–12, 14–15, 17, 19, 22–23, 25–26, 28, 30, 32–35, 37–44, 46–48, 50–56, 58, 60–61
linux.py20385%27, 43, 46
log.py1176147%1–11, 13–15, 17, 20–21, 23–24, 35, 38, 41, 45, 50–51, 58, 76, 81, 85, 89–93, 97, 103, 110, 121, 125, 127–130, 132, 134–135, 138–139, 146–149, 152, 157–158, 160, 165–166, 199, 205, 210
openocd.py45450%1–6, 8–9, 12, 17–18, 20–21, 23–25, 27, 35–36, 38–40, 42–44, 46, 57–58, 60, 63–68, 70, 72, 74–76, 78–79, 81, 83–84
plugin.py69232553%1–16, 31–33, 40–42, 44–48, 50–54, 57, 60, 238, 241, 244–245, 250–251, 254, 266, 270–274, 277–278, 286, 317, 322, 327–328, 331, 334, 351–352, 375, 378, 393–394, 401–402, 421–423, 442, 452, 455, 476–477, 482–483, 491–492, 497–499, 504–505, 516–517, 522–523, 528–529, 534–536, 541–543, 547–549, 553–555, 565–566, 568–569, 572–574, 578–580, 585–590, 592–594, 596–598, 600–602, 604, 606–607, 609–610, 612–619, 621–622, 625, 628–629, 655–657, 663, 667–668, 673–675, 693, 695, 704, 720–722, 727–729, 734–736, 744–746, 751–753, 758–760, 768–770, 775–777, 782–784, 789–791, 796–798, 803–805, 813–815, 820–822, 827–829, 834–836, 841–843, 851–853, 858–860, 865–867, 871–873, 878–880, 888–890, 895–897, 902–904, 909–911, 916–918, 926–928, 936, 940–942, 947, 950–952, 1098–1099, 1101–1102, 1110–1111, 1113–1114, 1154–1155, 1157, 1159, 1161, 1163, 1198–1200, 1207–1209, 1231–1233, 1238–1240, 1243–1245, 1250–1252, 1255–1257, 1262–1264, 1267–1269, 1300, 1302, 1304, 1309–1310, 1313–1314, 1319, 1327–1330, 1333, 1346, 1353–1354, 1366–1367, 1379–1380, 1391–1392, 1397–1401, 1405–1406, 1414–1415, 1424–1425, 1459–1460, 1466–1467, 1474
qemu.py231152%39–41, 43–44, 46–48, 50–51, 53
serial.py1162380%67–72, 76–77, 79, 83, 99, 169–170, 174, 179–182, 185, 188, 190, 197, 200
unity.py1805271%1–9, 11, 13, 18, 25, 31, 39–41, 44–45, 49, 55, 57, 65–66, 70–71, 73, 79, 82–84, 96–97, 114–115, 118, 141, 146, 148, 150, 157, 165, 170–171, 174, 181–182, 189–190, 193, 261–262
unity_tester.py1351985%14, 100–103, 120, 180–183, 243–244, 247, 252, 255–256, 261, 288, 290
utils.py753454%1–5, 7, 10, 25, 48, 51, 63, 66, 73, 83, 99, 105–106, 111–114, 116, 123, 127–132, 134, 141, 145, 153–154
TOTAL224282963% 

Tests Skipped Failures Errors Time
52 5 💤 0 ❌ 0 🔥 6m 20s ⏱️

@hfudev hfudev merged commit 91344f8 into main Jan 29, 2023
@hfudev hfudev deleted the fix/loadable_elf_rename branch January 29, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants