Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(idf): check sdkconfig items while erase_flash #266

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix(idf): check sdkconfig items while erase_flash #266

merged 1 commit into from
Mar 1, 2024

Conversation

hfudev
Copy link
Member

@hfudev hfudev commented Feb 29, 2024

No description provided.

@hfudev hfudev requested a review from horw February 29, 2024 13:24
@hfudev hfudev self-assigned this Feb 29, 2024
horw
horw reviewed Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@horw horw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for these changes.

@hfudev hfudev merged commit 28a52c8 into main Mar 1, 2024
5 checks passed
@hfudev hfudev deleted the fix/respect_sdkconfig_items_while_erase_flash branch March 1, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horw horw horw left review comments

Assignees

@hfudev hfudev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfudev @horw