Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Configuration Tool does not update for new configuration after changing device target (VSC-383) #144

Closed
boarchuz opened this issue Jul 21, 2020 · 1 comment · Fixed by #145
Assignees
Labels
bug Its an actual bug as determined by the maintainers

Comments

@boarchuz
Copy link
Contributor

Describe the bug
After changing target (ESP32<->ESP32S2), gui configuration tool does not reflect the updated target/sdkconfig until VSCode is restarted.

To Reproduce

  • Open an existing project.
  • Run "ESP-IDF: Launch gui configuration tool" so that "loading initial values" step completes.
  • Note target-specific options that are visible (eg. compiler path, "ESP32[xx]-specific" submenu, etc) and any changes from defaults.
  • Close the gui configuration tab.
  • Run "ESP-IDF: Set Espressif device target" and change to the other (at this point, it appears sdkconfig is reset)
  • Run "ESP-IDF: Launch gui configuration tool" again.
  • Note that the displayed values still reflect the old config (including previous device target), not the current values in sdkconfig.
  • Close VSCode and reopen project. Open the config gui again and now the current sdkconfig is shown correctly.

Expected behavior
Menuconfig gui always reflects the actual configuration.
Additionally, it would be great if configuration options that are common to all device targets are not reset when changing target. It is unexpected and unclear that changing target would reset the entire config to default.

Environment (please complete the following information):

  • OS Name & Version: Linux Mint
  • VSCode Version: 1.47.1
  • ESP-IDF Version: 4.2
  • Extension: 0.3.0
@github-actions github-actions bot changed the title GUI Configuration Tool does not update for new configuration after changing device target GUI Configuration Tool does not update for new configuration after changing device target (VSC-383) Jul 21, 2020
@brianignacio5 brianignacio5 self-assigned this Jul 21, 2020
@brianignacio5 brianignacio5 added the bug Its an actual bug as determined by the maintainers label Jul 21, 2020
@brianignacio5
Copy link
Collaborator

Thanks for reporting this. Will provide a fix soon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Its an actual bug as determined by the maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants