Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdkconfig and workspace watcher fixes for gui menuconfig #145

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Jul 21, 2020

Fix #144

Add onCreate and onDelete events for sdkconfig file watcher.

Dispose of Menuconfig when workspace changes or the selected project change.

Refactor ESP-IDF using await and put the spawn process within a progress bar.

@brianignacio5 brianignacio5 requested a review from pwmb July 21, 2020 10:44
@brianignacio5 brianignacio5 added the bugfix Fixing some issue and bug in this PR label Jul 21, 2020
@github-actions github-actions bot changed the title add create delete watch event add create delete watch event (VSC-384) Jul 21, 2020
@brianignacio5 brianignacio5 changed the title add create delete watch event (VSC-384) sdkconfig and workspace watcher fixes for gui menuconfig Jul 23, 2020
Copy link
Contributor

@pwmb pwmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit 76f1854 into espressif:master Jul 23, 2020
@pwmb pwmb added this to the Release Candidate v0.4.0 milestone Jul 23, 2020
@brianignacio5 brianignacio5 deleted the bugfix/sdkconfig-watch branch July 23, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI Configuration Tool does not update for new configuration after changing device target (VSC-383)
2 participants