Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: Background color broken (VSC-432) #164

Closed
ghost opened this issue Sep 13, 2020 · 2 comments · Fixed by #166
Closed

[Bug Report]: Background color broken (VSC-432) #164

ghost opened this issue Sep 13, 2020 · 2 comments · Fixed by #166
Assignees
Labels
bug Its an actual bug as determined by the maintainers

Comments

@ghost
Copy link

ghost commented Sep 13, 2020

After last update of VSCode from 1.48.2. to 1.49.0 I found that extension`s backgroung has ben broken.
Now all text almost invisible (including project configurator)
screenshot

@ghost ghost added the bug-report Bug Report from users on Github (don't use this tag manually, its supposed to be used via the issue) label Sep 13, 2020
@github-actions github-actions bot changed the title Background color broken [Bug Report]: Background color broken [Bug Report]: (VSC-432) Sep 13, 2020
@brianignacio5
Copy link
Collaborator

This is probably due to some change in vscode webview css variables which we reused in the Webviews.
Will take a look thanks for posting !

@pwmb pwmb changed the title Background color broken [Bug Report]: (VSC-432) [Bug Report]: Background color broken (VSC-432) Sep 14, 2020
@pwmb pwmb self-assigned this Sep 14, 2020
@pwmb pwmb added bug Its an actual bug as determined by the maintainers and removed bug-report Bug Report from users on Github (don't use this tag manually, its supposed to be used via the issue) labels Sep 14, 2020
@pwmb pwmb added this to the Release Candidate v0.5.0 milestone Sep 14, 2020
@pwmb
Copy link
Contributor

pwmb commented Sep 14, 2020

@brianignacio5 this is due to previously we were using background: transparent which then use to show dark background in a dark theme but now we explicitly have to tell vscode to paint the background accordingly

Will create a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Its an actual bug as determined by the maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants