Bugfix for webview background color issue #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master from espressif/vscode-esp-idf-extension
Merge commit
Master merge
merge from GH master
Sync Merge
Sync with master
Github Master sync
pwmb
added a commit
that referenced
this pull request
Dec 30, 2020
* Partition table editor initial commit * Update spectrum chat link to esp32 forum * Update tag and title * update tag on new issue * Update labels for feature request * Initial ESP-ADF and ESP-MDF support (VSC-380) (#140) * initial esp-adf support * fix images in examples html src * choose framework before loading examples * fix some images in markdown html * fix svg images * mv types marked to dev deps * add esp-mdf and examples * set MDF to MDF_PATH env variable * Add interface cfg-file into the default `idf.openOcdConfigs`config (#155) * Update prerequisite from Readme (#156) * Add CMake and Ninja prerequisite * Bump bl from 4.0.2 to 4.0.3 (#160) Bumps [bl](https://github.com/rvagg/bl) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](rvagg/bl@v4.0.2...v4.0.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove PR Sync with JIRA * Update debug adapter (#163) * Fix issue with the webview background color (#166) * Partition table editor initial commit * Add prop * Add state management * Add vue-select dep * Add json to csv conversion * Subtype type fix * Add some more functionality to the partition table viewer * Scroll auto * fix css issues * Add docs * Add support for csv file opening * Show warning and docs popup * Remove the header * Add action handler to refresh button * Add webview message handlers * Update Actions * add csv validation check * Update partition table * Remove bin file based open * Update docs to remove .bin related stuff * i18n added for the command * Update Header Text and Button * Add util method to read sdkconfig * Create partition table file if not exists * Add tooltip helper class * Add tooltip * Input validation function * Remove bin file support * Show info notification on save * Add support to show error popup to the users * 🐛 Fix some issue with update the webview Fix for: when user clicks a new csv file to be shown, re rednering was not happening properly * Add error on the UI * Support error and validation in store * remove unused var * Add build and flash buttons * Fix typos in docs * 🐛 Fix import issue * Remove unused component * Migrate to use codicon * Migrate to use codicon * Updated yarn lock file * Use IconifyIcon's codicon * Remove console.log * Use EOL instead of `\n` * EOL instead of \n * Update extension.ts Co-authored-by: Brian A. Ignacio <[email protected]> Co-authored-by: Andrei Gramakov <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrei Gramakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously webview was using
background: transparentbut now from vscodev1.49.xneed to explicitly specify the background color for the body based on the theme selected by the usersCloses #164