Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove win esp-matter #1052

Merged
merged 4 commits into from
Oct 11, 2023
Merged

remove win esp-matter #1052

merged 4 commits into from
Oct 11, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Sep 28, 2023

Description

Remove ESP-Matter setting for Windows and add validation for ESP-Matter command that is not available in Windows.

Remove Examples QuickPick from Progress Notification.

Fixes #1049
Fixes #1042

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-Matter" related command in Windows.
  2. Execute action. The command should show that this is only available on Windows.
  3. Observe results.
  • Expected behaviour:

  • Expected output:
    Message shown that this is not available on Windows.

How has this been tested?

Tested Manually

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Download the artifacts for this pull request:

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

Run any of those command on Windows 10 / ESP-IDF: v5.1.1 :

ESP-IDF: Install ESP-Matter / ESP-IDF: Install ESP-Matter Python Packages / ESP-IDF: Set ESP-Matter device

Nothing happens.
Do not see any info in console.

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !
Tested under:
OS - Windows 10 / Linux Ubuntu / MacOS

Windows - LGTM. Do see info message "ESP-Matter is not supported in Windows" on commands "ESP-IDF: Install ESP-Matter", "ESP-IDF: Install ESP-Matter Python Packages", "ESP-IDF: Set ESP-Matter Device PATH".

Linux - able to install ESP-Matter but do not see any info message about successful installation.
"ESP-IDF: Install ESP-Matter Python Packages", "ESP-IDF: Set ESP-Matter Device PATH".

MacOS - able to install ESP-Matter. Do not see any info message about successful installation.
"ESP-IDF: Install ESP-Matter Python Packages", "ESP-IDF: Set ESP-Matter Device PATH". - 👍

Should I create new ticket ?

@brianignacio5 brianignacio5 merged commit fb55b32 into master Oct 11, 2023
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/win-esp-matter branch October 11, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants