-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation using l10n vscode api #1178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download the artifacts for this pull request: |
brianignacio5
force-pushed
the
feature/i10n
branch
from
April 15, 2024 08:29
b3fd332
to
f54e819
Compare
5 tasks
brianignacio5
force-pushed
the
feature/i10n
branch
from
April 28, 2024 11:03
3326290
to
792c16e
Compare
radurentea
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@brianignacio5 hi ! Tested under: Do see commands translated to supported languages (Chinese, English, Spanish, Russian). LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
vscode.l10n.t()
for source code translation to reduce translation files and phrases duplication.Add missing translation from package.json to fix GitHub issue.
Add Portuguese translation.
Fixes #1165
Fixes #567
Type of change
Steps to test this pull request
This PR provides a list of translations. You need to switch vscode language to observer commands and text translation.
How has this been tested?
Manual Testing
Test Configuration:
Checklist