Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update instruction (VSC-1361) #1188

Merged
merged 1 commit into from
May 24, 2024
Merged

docs: update instruction (VSC-1361) #1188

merged 1 commit into from
May 24, 2024

Conversation

kowyo
Copy link
Contributor

@kowyo kowyo commented May 12, 2024

Description

The text in the docs does not match what it is in the extension, and may lead to some misunderstanding for the new-comers, hence I made some modification.

It does not fix any issue yet, if needed, I could create one.

Type of change

  • This change requires a documentation update

Steps to test this pull request

No, it is simply a docs change.

How has this been tested?

You could use the extension and may found the
text inconsistent with the docs.

Test Configuration:

  • ESP-IDF Version: 5.2.1, Latest
  • OS (Windows,Linux and macOS): macOS

Dependent components impacted by this PR:

No, nothing would be impacted except the document itself.

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@kowyo
Copy link
Contributor Author

kowyo commented May 24, 2024

Hi, @brianignacio5 , would you like me to know why this PR hasn't been reviewed yet for two weeks?

@github-actions github-actions bot changed the title docs: update instruction docs: update instruction (VSC-1361) May 24, 2024
@brianignacio5
Copy link
Collaborator

Sorry @kowyo I just reviewed it. Thanks for your contribution ! :)

@brianignacio5 brianignacio5 merged commit 633c244 into espressif:master May 24, 2024
6 checks passed
@kowyo kowyo deleted the patch-1 branch May 24, 2024 07:59
@kowyo
Copy link
Contributor Author

kowyo commented May 24, 2024

Thank you for reviewing this!❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants