Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add esp insights framework support #1205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented May 30, 2024

Description

Add ESP-Insights as supported framework to install and set the idf.espInsightsPath. It will use the setting as INSIGHTS_PATH as env variable for the extension tasks.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Install ESP-Insights"
  2. Execute action. The repository will be cloned and the idf.espInsightsPath settings will be updated.
  3. Click on "ESP-IDF: Show Examples" and choose ESP-Insights. Pick an example
  4. Try to build the example after configuring this example as required. Some changes to idf_component.yml might be required to remove idf_component manager behavior.
  • Expected behaviour:

  • Expected output:

Test Configuration:

  • ESP-IDF Version: 4.4
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this May 30, 2024
Copy link

github-actions bot commented May 30, 2024

Download the artifacts for this pull request:

Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Jun 15, 2024
@github-actions github-actions bot closed this Jun 20, 2024
@brianignacio5 brianignacio5 reopened this Jun 20, 2024
@brianignacio5 brianignacio5 added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant