-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1213] Enhance flash encryption #1247
base: master
Are you sure you want to change the base?
Conversation
Download the artifacts for this pull request: |
This PR is not ready to be tested / code reviewed:
|
Pull request has been marked as |
33707d0
to
f069d59
Compare
Hi @brianignacio5, Please take another look for the new commits in regards to the error handling of JTAG Flash when efuses are burnt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes
ddf3121
to
58fc5a7
Compare
47b9390
to
41fabfb
Compare
Hi @brianignacio5 PTAL, I've made the modifications you've requested |
41fabfb
to
48c1f04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes regarding deprecating idf.adapterTargetName and moving to docs_espressif documentation.
154576b
to
b002152
Compare
Hi @brianignacio5, Thank you for the code review! I've done the changes you've requested. Please take another look. |
12b928c
to
4ba59b0
Compare
|
||
const idfTarget = await getIdfTargetFromSdkconfig(workspaceRoot); | ||
const eFuse = new ESPEFuseManager(workspaceRoot); | ||
const data = await eFuse.readSummary(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readSummary function takes some time to load and the user doesn't see any information until it is completed. Suggestion wrapping this function into
vscode.window.withProgress(
{
cancellable: true,
location: ProgressLocation,
title: "ESP-IDF: Checking encryption eFuse...",
},
async (
progress: vscode.Progress<{
message: string;
increment: number;
}>,
cancelToken: vscode.CancellationToken
) => {}
);
Tested using esp32 Core board using esp-idf v5.4 with flash_encryption example.
Otherwise LGTM
Description
Added check for SDK config modifications for encryption.
Fixes #1067
Type of change
Steps to test this pull request
EX:
Test Configuration:
Checklist