-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix support for multiple sdkconfig files #1252
Conversation
Download the artifacts for this pull request: |
Hello. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @executer-uno , please take a look at latest changes. It should kill the current sdkconfig editor process as described in your GitHub issue. |
Thanks. That one tested and no issues left, as for me. |
f485dd7
to
ee1b140
Compare
Pull request has been marked as |
Pull request has been marked as |
fddd0d5
to
d18baa4
Compare
cc0d319
to
9024eee
Compare
Tested on Windows 11 and Ubuntu 24.04 environment. The sdkconfig files define in the project configuration abe being updated properly when running menuconfig, instead of the file in the build folder. |
Description
Fix support of multiple sdkconfig when using Project Configuration and multiple profiles.
Fixes #1202
Fixes #1265
Fixes #1283
Fixes #1299
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Using a project with multiple configurations like https://github.com/espressif/esp-idf/tree/master/examples/build_system/cmake/multi_config run the
ESP-IDF: Open Project Configuration
and configure 2 profiles with different SDK Configuration Editor, resulting in aesp_idf_project_configuration.json
like this:Note: If using the former ESP-IDF multi config example, remember to remove from root CMakeLists.txt the line:
Click on "SDK Configuration Editor" using profile 1. SDK Configuration changes should be saved in
${workspaceFolder}/sdkconfig1
and c_cpp_properties.json should have compileCommands set to the build path of profile 1.Click on "SDK Configuration Editor" using profile 2. SDK Configuration changes should be saved in
${workspaceFolder}/sdkconfig2
and c_cpp_properties.json should have compileCommands set to the build path of profile 2.Observe results.
Expected behaviour:
Expected output:
How has this been tested?
Manual Testing
Test Configuration:
Checklist