-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for pwsh users #1279
Fix for pwsh users #1279
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, Brian! @AndriiFilippov PTAL |
Hi @Fabricio-ESP, when you have time please take a look |
On Linux the Build and Flash commands works without any issue, but the monitor commands is showing unexpected behavior. Additionally, when re-executing the monitor command, the command is not properly finishing the previous task before sending new commands. |
f52780c
to
c02fff5
Compare
Confirm it is working now with the latest changes. Command is not repeated in shell and it is working well in Windows and Linux. |
Description
Fixes monitoring for users that have Powershell executable as pwsh.exe
Fixes #1275
Type of change
Steps to test this pull request
Go to the official PowerShell GitHub repository release page: https://github.com/PowerShell/PowerShell/releases
Look for the latest stable release and download the appropriate installer for your system (e.g., PowerShell-7.3.x-win-x64.msi for 64-bit Windows).
Double-click the downloaded MSI file and follow the installation wizard.
Open a new command prompt or Windows PowerShell window and type:
pwsh
pwsh
as default terminal in vscode and to build, flash monitor a project on an esp board.Checklist