Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pwsh users #1279

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Fix for pwsh users #1279

merged 2 commits into from
Oct 1, 2024

Conversation

radurentea
Copy link
Collaborator

@radurentea radurentea commented Aug 12, 2024

Description

Fixes monitoring for users that have Powershell executable as pwsh.exe

Fixes #1275

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

  1. Download the installer:
    Go to the official PowerShell GitHub repository release page: https://github.com/PowerShell/PowerShell/releases
    Look for the latest stable release and download the appropriate installer for your system (e.g., PowerShell-7.3.x-win-x64.msi for 64-bit Windows).
  2. Run the installer:
    Double-click the downloaded MSI file and follow the installation wizard.
  3. Verify the installation:
    Open a new command prompt or Windows PowerShell window and type: pwsh
  4. Set pwsh as default terminal in vscode and to build, flash monitor a project on an esp board.
  5. Everything should work fine.

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea self-assigned this Aug 12, 2024
Copy link

github-actions bot commented Aug 12, 2024

Download the artifacts for this pull request:

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radurentea
Copy link
Collaborator Author

Thank you, Brian!

@AndriiFilippov PTAL

@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Aug 26, 2024
@radurentea
Copy link
Collaborator Author

Hi @Fabricio-ESP, when you have time please take a look

@Fabricio-ESP
Copy link
Collaborator

Fabricio-ESP commented Sep 24, 2024

Using VSCode 1.9 this issue does not happen anymore on Windows, since VSCode will run the commands using the "default" terminal for the operating system, which on windows is PowerShell.

On Linux the Build and Flash commands works without any issue, but the monitor commands is showing unexpected behavior.
The command sent to terminal still uses "export" which is not understood by PowerShell 7. Additionally, it seems that the python path and the monitor command is being sent twice to the terminal application.

image

Additionally, when re-executing the monitor command, the command is not properly finishing the previous task before sending new commands.

image

@Fabricio-ESP
Copy link
Collaborator

Confirm it is working now with the latest changes. Command is not repeated in shell and it is working well in Windows and Linux.

@radurentea radurentea merged commit bf9df82 into master Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParserError when opening "ESP-IDF: Monitor Device" (VSC-1459)
3 participants