-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate output; Add notification for success #1290
base: master
Are you sure you want to change the base?
Fix duplicate output; Add notification for success #1290
Conversation
Download the artifacts for this pull request: |
Hi @brianignacio5, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can still see the same message being output in 2 places.
Suggest further reduce code duplication here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @Fabricio-ESP , PTAL |
Pull request has been marked as |
Description
Removed duplicated output to ESP-IDF channel, when user sets device target (ex: esp32, esp32s2 etc)
Added notification for successfully setting the target
Improved error message
JIRA: https://jira.espressif.com:8443/browse/VSC-1430
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Executing "cmake
How has this been tested?
As described above
Test Configuration:
Checklist