Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VSC-1430] Fix duplicate output; Add notification for success #1290

Merged
merged 2 commits into from
Oct 25, 2024
Merged

[VSC-1430] Fix duplicate output; Add notification for success #1290

merged 2 commits into from
Oct 25, 2024

Conversation

radurentea
Copy link
Collaborator

Description

Removed duplicated output to ESP-IDF channel, when user sets device target (ex: esp32, esp32s2 etc)
Added notification for successfully setting the target
Improved error message

JIRA: https://jira.espressif.com:8443/browse/VSC-1430

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

  1. Open a project
  2. Set any device target
  3. Check "ESP-IDF" Output channel. There should be no duplicates of Executing "cmake
  4. When setting the device is finished, you should get a notification no matter if it's successful or not.

How has this been tested?

As described above

Test Configuration:

  • ESP-IDF Version: 5.2.2
  • OS (Windows,Linux and macOS): Windows 11

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea added the needs translation:CN Chinese translation is required label Aug 26, 2024
@radurentea radurentea self-assigned this Aug 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@radurentea
Copy link
Collaborator Author

Hi @brianignacio5, PTAL

brianignacio5
brianignacio5 requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can still see the same message being output in 2 places.

Suggest further reduce code duplication here.

src/espIdf/setTarget/index.ts Outdated Show resolved Hide resolved
brianignacio5
brianignacio5 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radurentea
Copy link
Collaborator Author

Hi @Fabricio-ESP , PTAL

@github-actions GitHub Actions
Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Sep 26, 2024
@radurentea radurentea added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Sep 30, 2024
@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Oct 14, 2024
@Fabricio-ESP Fabricio-ESP changed the title Fix duplicate output; Add notification for success [VSC-1430] Fix duplicate output; Add notification for success Oct 22, 2024
@radurentea radurentea force-pushed the enhance/remove-extra-logging-for-setting-target branch from 4b9b4a1 to 1fab9da Compare October 23, 2024 11:21
brianignacio5
brianignacio5 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fabricio-ESP
Fabricio-ESP approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows, Linux ubuntu and on WSL ubuntu.
Cmake only run once no issues found on normal operation of the extension.

@radurentea radurentea merged commit 11532cb into master Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianignacio5 brianignacio5 brianignacio5 approved these changes

@Fabricio-ESP Fabricio-ESP Fabricio-ESP approved these changes

Assignees

@radurentea radurentea

Labels
needs translation:CN Chinese translation is required ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@radurentea @brianignacio5 @Fabricio-ESP