-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1478] Disable cmds for Codespaces and redirect Flash monitor to Web extension #1297
Conversation
Download the artifacts for this pull request: |
c27cd56
to
1fc799e
Compare
PTAL @radurentea @Fabricio-ESP |
Tested on Windows and Linux. On Windows it is still not possible to flash the device. The extension does not properly resolve the path for the build artifacts, showing the error: This works as expected on Ubuntu, so a limitation on Windows on how to resolve the workspace page. Adding this to the .vscode/settings.json allows successfully flashing of the device. "idf.buildPath" : "/workspaces/vscode-extension-codespace-test/build" |
I have tested on Mac, but I was not able to flash the project because I was not able to select a serial port. Steps to reproduce:
I will try again tomorrow, maybe I've misconfigured something or I've left the codespace sit in my tab for too long before testing. |
@radurentea Did you install the web extension in the browser? When I open the codespace in the browser, along with installing the vsix I need to select "install in the browser" in the web extension. Oh Oh, note, @brianignacio5 the bot did not update the artifact in the PR after your last commit, we need to download the artifact directly from the CI action: https://github.com/espressif/vscode-esp-idf-extension/actions/runs/11303927905?pr=1297 |
Thank you @Fabricio-ESP, I've made it work, the problem I think it was a combination of bad .vsix and probably I did not press the "install in the browser" for the web extension. I've tested on Mac. The commands work as expected, but it seems the serial port has some strange behavior: It doesn't appear in the status bar, until I flash or monitor the device It seems that for each run of flashing or monitoring, we spawn the "serial port" status item If I continue to use the commands mentioned, new "serial port" status item will appear. |
PR Comment bug fix #1328
Could you describe the steps to reproduce this behavior ? Which commands did you use ? Both of these issues seems to be IDF Web extension related. Are the functionality in this PR (redirects commands to IDF Web extension command) work ? If that is the case we should proceed with review. Regarding IDF Web extension, I'll create an issue in the repository and add a fix there. Testing, unfortunately can't be done in Codespaces as far as I know. Need to test locally as described in IDF Web extension readme. |
Hi @brianignacio5, @Fabricio-ESP, I agree that we can move forwards with the PR, since it's not related to the changes. Steps to reproduce the issues with multiple serial ports items in the status bar (I used Mac M1 with Sequoia 15.0.1):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianignacio5
Should we create a ticket to investigate the serial port entries from the web extension? If you create such ticket, please add reference here. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… web extension
Description
Add
UIKind.Web
validation for Codespaces to disable commands not available in Browser or Codespaces and redirect Flash and monitor commands to ESP-IDF Web extensionType of change
Steps to test this pull request
Open VSCode Extension codespace test in Codespaces. Uninstall the ESP-IDF extension that was pre installed. Load this PR vsix installer into the current Codespaces directory and install vsix from there to Codespaces (install from local doesn't work for me).
ESP-IDF: Flash your project
or Flash icon from status bar, the extension will call the ESP-IDF Web extension flash command. Same forESP-IDF: Monitor your device
to call web extension monitor command.ESP-IDF: Build, flash and monitor
. You should receive a notification error message that command is not available in Web.Expected behaviour:
Expected output:
How has this been tested?
Manual testing using steps above.
Test Configuration:
Checklist