Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use idf tools export to get env vars #1343

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

brianignacio5
Copy link
Collaborator

Description

Use idf_tools.py export --format key-value to get ESP-IDF variables required in environment variables.

This should fix missing ESP_IDF_VERSION from extension tasks and use PATH from idf_tools.py (which is already done but could replace extension implementation.)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Probably the best way to verify that variables are present is to open ESP-IDF: Open ESP-IDF Terminal and do echo $ESP_IDF_VERSION or other environment variable from idf_tools.py export output.

You can also test with any command like ESP-IDF: Build your project but harder to see if variables are available.

  • Expected behaviour:

All variables from idf_tools.py export --format key-value should be available in extension commands like ESP-IDF: Open ESP-IDF Terminal

Test Configuration:

  • ESP-IDF Version: 4.4 , 4.4.8, 5.0.4 5.4
  • OS (Windows,Linux and macOS): macOS Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Nov 18, 2024
@brianignacio5 brianignacio5 self-assigned this Nov 18, 2024
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant