-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify onboarding (VSC-426) #159
Simplify onboarding (VSC-426) #159
Conversation
b1ec04d
to
6902678
Compare
1fcb232
to
59b5ee4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I select the folder with IDF already there and try to install latest version of idf its going to this next page and UI freezes, ideally if folder had IDF already IDF, show the warning to user that this will override any changes they have there, and they can press Yes
or Continue
to proceed
Use existing ESP-IDF setup
button is non functional!!
Old error is persisting, even after changing the directory (should be reactive)
Same here
Hmm should redirected to install page if error happens. Will fix.
Any error in the logs or vscode Developer Tools console ? |
This should be fixed. Please check the other errors. |
52e3dbd
to
cbbeac4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS Suggestions
- Add a box/border around so that these options just don't like text
- On mouse Hover on them change cursor to pointer to indicate link
- Also on hover change the text to blue (which is already the current behavior)
- Left align the content in card (not center) and Right align the action buttons
- First screen for both
Express
&Advance
are identical is this intensional ?
CSS suggestions should have been fixed.
Yes because it is necessary for both advanced and express setup modes. Tools need ESP-IDF to be defined first in any case. |
Advanced allows you to modify Tools directory folder or enter each tool path manually.
No it is not. Fixed other issues mentioned by @kumekay Please take a look again when possible. |
…vscode-esp-idf-extension into feature/simple-onboarding
This branch is built to simplify user setup window.
~/.espressif
or%USERPROFILE%/.espressif
. If the user updates $IDF_TOOLS_PATHDebug Adapter and Extension requirements
in virtual environment found.